fix(opencode): prefer semantic ACP tool title and input before completion#23948
Open
nizheming wants to merge 1 commit intoanomalyco:devfrom
Open
fix(opencode): prefer semantic ACP tool title and input before completion#23948nizheming wants to merge 1 commit intoanomalyco:devfrom
nizheming wants to merge 1 commit intoanomalyco:devfrom
Conversation
be0ae80 to
7df021a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #23947
Type of change
What does this PR do?
This fixes ACP tool progress events using generic metadata before completion.
tool_callandtool_call_update(status=in_progress)were sendingpart.tooland sometimes empty input, so ACP clients showed generic labels likebashorskillwhile the tool was running.This change makes ACP prefer semantic state before completion:
title:part.state.title ?? part.toolrawInput:part.state.input ?? {}locations: recomputed from the best available inputCompleted behavior is unchanged.
How did you verify your code works?
packages/opencode/test/acp/event-subscription.test.tsbun test test/acp/event-subscription.test.tsfrompackages/opencodebun typecheckfrompackages/opencodeScreenshots / recordings
N/A
Checklist